Verilog: constant folding for reduction operators #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
changed the title
tautschnig
approved these changes
Aug 13, 2024
Comment on lines
+1548
to
+1563
| auto make_all_ones = [](const typet &type) -> exprt | ||
| { | ||
| if(type.id() == ID_unsignedbv) | ||
| { | ||
| return from_integer( | ||
| power(2, to_unsignedbv_type(type).get_width()) - 1, type); | ||
| } | ||
| else if(type.id() == ID_signedbv) | ||
| { | ||
| return from_integer(-1, type); | ||
| } | ||
| else if(type.id() == ID_bool) | ||
| return true_exprt{}; | ||
| else | ||
| PRECONDITION(false); | ||
| }; |
There was a problem hiding this comment.
Wouldn't bv_typet::all_ones_expr do the trick?
There was a problem hiding this comment.
Not sure if the simplifier can cast that? Will check.
Romy15200
pushed a commit
to Romy15200/nws
that referenced
this pull request
Aug 19, 2025
Verilog: constant folding for reduction operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.