[22704] Support compiler MSYS2-MinGW #5600

RookieCLY · 2025-01-25T07:45:23Z

Support compilation using MinGW. Version: MSYS2-MinGW-V14.2, x86_64-w64-mingw32.

Description

The ‘COMPILE_TOOLS’ compilation option is turned off when compiling with MinGW because there are still some issues that have not been resolved here, but it does not affect the use of the main body of fastdds.
The import and export settings in thefastdds_dll.hpp file were changed to adapt to the symbol import and export rules of mingw. Tests found that these changes were effective.
The macro definition 'MINGW_COMPILER' has been added in cmakelists.txt to control some code to move towards new branches, which are used to resolve library dependency differences between compilers.
Some compile-time warnings that do not affect use have been canceled. 'ws2_32' and 'mswsock' libraries have been manually linked. The above changes are written in cmakelists.txt and will only take effect when the compiler is MinGW.
Almost all changes only take effect when the compiler is MinGW. Before compiling Fast-DDS with MinGW, it was best to use MinGW to compile its dependent libraries, such as fastcdr, tinyxml2 and foonathan_memory.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Fixes #5575

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
_N/A_New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Javgilavi

The pull request looks great overall!
Could you please make a few minor adjustments to align it with our uncrustify style guidelines so that it passes our CI checks?

src/cpp/fastdds/xtypes/serializers/json/dynamic_data_json.cpp

src/cpp/utils/SystemInfo.cpp

src/cpp/utils/TimedConditionVariable.cpp

RookieCLY · 2025-02-05T10:03:19Z

Hi, @Javgilavi . Thanks for the advice, I will do it soon. By the way, are there any other advice for the CI checks, like DCO and so on?

Javgilavi · 2025-02-05T10:59:17Z

Hi @RookieCLY,

Thanks for asking! I was actually about to mention the DCO issue, so you beat me to it.

In the CI output, you can click on the DCO Details link, which provides clear instructions on how to fix the problem. Essentially, you need to sign off your commits. Everything you need is explained in that section.

If you have any further questions or need additional help, feel free to ask.

Javgilavi

Sorry for being a bit picky with the review, but these changes are necessary to pass the CI.

src/cpp/fastdds/xtypes/serializers/json/dynamic_data_json.cpp

src/cpp/utils/SystemInfo.cpp

Javgilavi · 2025-02-06T12:04:02Z

And for the DCO looks like it's still giving error.

Your new commit is fine:

But in your original commit it still appears wrongly:

The "Signed-off-by: RookieCLY … " should appear in the second line (this automatically do with the commit -s) and also it says the commiter was "cuily" and not "RookieCLY", they need to be the same.

Follow the instruction of the DCO

If you have ant doubt about how to do it, just ask!!
And also thanks for the PR!!

Signed-off-by: RookieCLY <[email protected]>

…osima#5575 Signed-off-by: RookieCLY <[email protected]>

Javgilavi

LGTM

RookieCLY · 2025-02-07T07:35:12Z

Hi, @Javgilavi .
It seems that there is something wrong with MacOS CI, but I don't quite understand it. I just changed some code formats. What should I do next?

Javgilavi · 2025-02-07T07:47:55Z

Hi @RookieCLY,

Don't worry about it, it's not related to your changes.
It's not a problem.

MiguelCompany · 2025-02-07T07:49:44Z

@RookieCLY Failed test on MacOS is known to be flakey.

Thank you for your contribution and your patience!

MiguelCompany · 2025-02-07T07:50:22Z

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

mergify · 2025-02-07T07:50:30Z

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

#5632 [22704] Support compiler MSYS2-MinGW (backport #5600) has been created for branch 3.1.x
#5633 [22704] Support compiler MSYS2-MinGW (backport #5600) has been created for branch 3.0.x
#5634 [22704] Support compiler MSYS2-MinGW (backport #5600) has been created for branch 2.14.x but encountered conflicts
#5635 [22704] Support compiler MSYS2-MinGW (backport #5600) has been created for branch 2.10.x but encountered conflicts

* feature: support compiler MSYS2-MinGW #5575 Signed-off-by: RookieCLY <[email protected]> * feature: support compiler MSYS2-MinGW #5575 Signed-off-by: RookieCLY <[email protected]> * feature: support compiler MSYS2-MinGW and fix some format problem #5575 Signed-off-by: RookieCLY <[email protected]> --------- Signed-off-by: RookieCLY <[email protected]> (cherry picked from commit 28b11ca)

* feature: support compiler MSYS2-MinGW #5575 Signed-off-by: RookieCLY <[email protected]> * feature: support compiler MSYS2-MinGW #5575 Signed-off-by: RookieCLY <[email protected]> * feature: support compiler MSYS2-MinGW and fix some format problem #5575 Signed-off-by: RookieCLY <[email protected]> --------- Signed-off-by: RookieCLY <[email protected]> (cherry picked from commit 28b11ca) # Conflicts: # include/fastdds/fastdds_dll.hpp # src/cpp/fastdds/xtypes/serializers/json/dynamic_data_json.cpp # src/cpp/utils/TimedConditionVariable.cpp

Javgilavi changed the title ~~Support compiler MSYS2-MinGW~~ [22704] Support compiler MSYS2-MinGW Jan 27, 2025

juanlofer-eprosima mentioned this pull request Jan 28, 2025

[22704] Link problem with MinGW #5575

Closed

1 task

Javgilavi self-requested a review February 4, 2025 15:02

Javgilavi added this to the v3.2.0 milestone Feb 4, 2025

Javgilavi reviewed Feb 5, 2025

View reviewed changes

Javgilavi reviewed Feb 6, 2025

View reviewed changes

RookieCLY force-pushed the feature/mingw-compile branch 2 times, most recently from 4c9dfd3 to 680e6e4 Compare February 6, 2025 12:25

Javgilavi self-requested a review February 6, 2025 13:11

MiguelCompany force-pushed the feature/mingw-compile branch from a3cfef0 to 8ac3809 Compare February 6, 2025 13:40

MiguelCompany requested review from Javgilavi and removed request for Javgilavi February 6, 2025 13:40

RookieCLY added 3 commits February 6, 2025 14:50

feature: support compiler MSYS2-MinGW eProsima#5575

ee9ff48

Signed-off-by: RookieCLY <[email protected]>

feature: support compiler MSYS2-MinGW eProsima#5575

2d7a68e

Signed-off-by: RookieCLY <[email protected]>

feature: support compiler MSYS2-MinGW and fix some format problem ePr…

ae9e889

…osima#5575 Signed-off-by: RookieCLY <[email protected]>

MiguelCompany force-pushed the feature/mingw-compile branch from 8ac3809 to ae9e889 Compare February 6, 2025 13:51

MiguelCompany requested review from Javgilavi and removed request for Javgilavi February 6, 2025 13:51

Javgilavi approved these changes Feb 7, 2025

View reviewed changes

MiguelCompany added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 7, 2025

MiguelCompany merged commit 28b11ca into eProsima:master Feb 7, 2025
16 of 17 checks passed

This was referenced Feb 7, 2025

[22704] Support compiler MSYS2-MinGW (backport #5600) #5632

Open

[22704] Support compiler MSYS2-MinGW (backport #5600) #5633

Open

mergify bot mentioned this pull request Feb 7, 2025

[22704] Support compiler MSYS2-MinGW (backport #5600) #5634

Open

14 tasks

mergify bot mentioned this pull request Feb 7, 2025

[22704] Support compiler MSYS2-MinGW (backport #5600) #5635

Open

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[22704] Support compiler MSYS2-MinGW #5600

[22704] Support compiler MSYS2-MinGW #5600

RookieCLY commented Jan 25, 2025 •

edited by MiguelCompany

Loading

Javgilavi left a comment

RookieCLY commented Feb 5, 2025

Javgilavi commented Feb 5, 2025

Javgilavi left a comment

Javgilavi commented Feb 6, 2025

Javgilavi left a comment

RookieCLY commented Feb 7, 2025

Javgilavi commented Feb 7, 2025

MiguelCompany commented Feb 7, 2025

MiguelCompany commented Feb 7, 2025

mergify bot commented Feb 7, 2025 •

edited

Loading

[22704] Support compiler MSYS2-MinGW #5600

[22704] Support compiler MSYS2-MinGW #5600

Conversation

RookieCLY commented Jan 25, 2025 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

Javgilavi left a comment

Choose a reason for hiding this comment

RookieCLY commented Feb 5, 2025

Javgilavi commented Feb 5, 2025

Javgilavi left a comment

Choose a reason for hiding this comment

Javgilavi commented Feb 6, 2025

Javgilavi left a comment

Choose a reason for hiding this comment

RookieCLY commented Feb 7, 2025

Javgilavi commented Feb 7, 2025

MiguelCompany commented Feb 7, 2025

MiguelCompany commented Feb 7, 2025

mergify bot commented Feb 7, 2025 • edited Loading

✅ Backports have been created

RookieCLY commented Jan 25, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Feb 7, 2025 •

edited

Loading