Skip to content

Conversation

@MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 12, 2025

Description

This changes TwoPublishersCommunicationReliable to use the same launch mechanism as other tests in the same folder.

It also reduces the flakiness in RefCountedPointerTests.

We hope to see a full green on MacOS with these changes.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.1 milestone Nov 12, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima November 12, 2025 11:11
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 12, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2025

🧪 CI Insights

Here's what we observed from your CI run for eed6f04.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@MiguelCompany MiguelCompany modified the milestones: v3.4.1, v3.4.2 Nov 13, 2025
@MiguelCompany MiguelCompany merged commit d538426 into master Nov 19, 2025
27 of 31 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/23732 branch November 19, 2025 07:41
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 3.3.x 3.2.x 2.14.x

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`

Signed-off-by: Miguel Company <[email protected]>

* Refs #23732. Improve RefCountedPointerTests.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit d538426)
@mergify mergify bot mentioned this pull request Nov 19, 2025
12 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`

Signed-off-by: Miguel Company <[email protected]>

* Refs #23732. Improve RefCountedPointerTests.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit d538426)
@mergify mergify bot mentioned this pull request Nov 19, 2025
12 tasks
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`

Signed-off-by: Miguel Company <[email protected]>

* Refs #23732. Improve RefCountedPointerTests.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit d538426)
@mergify mergify bot mentioned this pull request Nov 19, 2025
12 tasks
MiguelCompany added a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`



* Refs #23732. Improve RefCountedPointerTests.



---------


(cherry picked from commit d538426)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`



* Refs #23732. Improve RefCountedPointerTests.



---------


(cherry picked from commit d538426)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable`



* Refs #23732. Improve RefCountedPointerTests.



---------


(cherry picked from commit d538426)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants