-
Notifications
You must be signed in to change notification settings - Fork 875
[23732] Improve some tests #6167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+64
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
richiware
requested changes
Nov 12, 2025
richiware
approved these changes
Nov 12, 2025
Contributor
🧪 CI InsightsHere's what we observed from your CI run for eed6f04. ❌ Job Failures
|
Member
Author
|
@Mergifyio backport 3.3.x 3.2.x 2.14.x |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` Signed-off-by: Miguel Company <[email protected]> * Refs #23732. Improve RefCountedPointerTests. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit d538426)
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` Signed-off-by: Miguel Company <[email protected]> * Refs #23732. Improve RefCountedPointerTests. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit d538426)
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` Signed-off-by: Miguel Company <[email protected]> * Refs #23732. Improve RefCountedPointerTests. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit d538426)
12 tasks
MiguelCompany
added a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` * Refs #23732. Improve RefCountedPointerTests. --------- (cherry picked from commit d538426) Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` * Refs #23732. Improve RefCountedPointerTests. --------- (cherry picked from commit d538426) Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
Nov 19, 2025
* Refs #23732. Use cmake wrapper for `TwoPublishersCommunicationReliable` * Refs #23732. Improve RefCountedPointerTests. --------- (cherry picked from commit d538426) Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes
TwoPublishersCommunicationReliableto use the same launch mechanism as other tests in the same folder.It also reduces the flakiness in
RefCountedPointerTests.We hope to see a full green on MacOS with these changes.
@Mergifyio backport 3.3.x 3.2.x 2.14.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist