Skip to content

Conversation

@wep21
Copy link
Contributor

@wep21 wep21 commented Nov 18, 2025

Description

  • update old log macro
  • Disable old log macros when building in CI

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • N/A: Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.4.2 milestone Nov 19, 2025
@MiguelCompany MiguelCompany self-requested a review November 19, 2025 07:14
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 19, 2025
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany November 19, 2025 07:19
@MiguelCompany MiguelCompany changed the title chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h Nov 19, 2025
@MiguelCompany MiguelCompany merged commit 3aa2026 into eProsima:master Nov 19, 2025
25 of 42 checks passed
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.3.x 3.2.x

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

backport 3.3.x 3.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Disable old log macros in fastdds build config

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 3aa2026)
mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Disable old log macros in fastdds build config

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 3aa2026)
@MiguelCompany
Copy link
Member

@wep21 Thank you!

@MiguelCompany
Copy link
Member

@Mergifyio backport 2.14.x

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2025

backport 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2025
* chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Disable old log macros in fastdds build config

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 3aa2026)
MiguelCompany added a commit that referenced this pull request Nov 19, 2025
…6179)

* chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h



* Disable old log macros in fastdds build config



---------




(cherry picked from commit 3aa2026)

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 19, 2025
…6180)

* chore: replace logWarning with EPROSIMA_LOG_WARNING in RTCPHeader.h



* Disable old log macros in fastdds build config



---------




(cherry picked from commit 3aa2026)

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants