Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-monorepo): DSW-2172 pie-design-tokens update #1861

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

dandel10n
Copy link
Contributor

@dandel10n dandel10n commented Sep 13, 2024

Describe your changes (can list changeset entries if preferable)


"wc-vanilla": minor
"pie-storybook": minor
"pie-docs": minor
"pie-monorepo": minor

[Changed] - pie-design-tokens version bump to 6.5.0.


"@justeattakeaway/pie-css": minor

[Changed] - replaces hardcoded breakpoint values with PIE tokens.


"@justeattakeaway/pie-cookie-banner": patch

[Removed] - pie-design-tokens dependency.


"@justeattakeaway/pie-notification": minor
"@justeattakeaway/pie-modal": minor

[Changed] - replaces media with include-media with pie breakpoints tokens.

It also updates the usage of scss var for ::backdrop in modal component with css value since the bug has been fixed. I still had to leave the old scss option for Safari <v17.6 temporary until we drop the support of v16.

I checked in Browserstack the following browsers:
Firefox: 130, 129, 128
Chrome: 128, 127, 126
Opera: 113, 112, 111
Edge: 128, 127, 126
Safari: 17.6 worked fine on my machine but didn't show the backdrop in browserstack on older versions.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 @kevinrodrigues

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 @maledr5

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 6904c06

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch 6 times, most recently from 0e4e96c to 9038f06 Compare September 17, 2024 13:41
@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch from 9038f06 to dd86ec7 Compare September 17, 2024 13:46
@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch from dd86ec7 to d1e419f Compare September 18, 2024 08:53
@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch 5 times, most recently from 4546d1c to 7a8ccd8 Compare September 19, 2024 12:51
@dandel10n dandel10n marked this pull request as ready for review September 19, 2024 13:16
@dandel10n dandel10n requested review from a team as code owners September 19, 2024 13:16
@dandel10n
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@dandel10n Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch from bcf9654 to 8154537 Compare September 19, 2024 17:18
@dandel10n dandel10n force-pushed the dsw-2172-pie-design-tokens-v-bump branch from 8154537 to 2a22a8f Compare September 20, 2024 09:22
@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@dandel10n Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@dandel10n dandel10n requested a review from raoufswe September 20, 2024 09:32
@dandel10n dandel10n merged commit 77dea2f into main Sep 23, 2024
58 of 59 checks passed
@dandel10n dandel10n deleted the dsw-2172-pie-design-tokens-v-bump branch September 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants