-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-monorepo): DSW-2172 pie-design-tokens update #1861
Conversation
🦋 Changeset detectedLatest commit: 6904c06 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0e4e96c
to
9038f06
Compare
9038f06
to
dd86ec7
Compare
dd86ec7
to
d1e419f
Compare
4546d1c
to
7a8ccd8
Compare
/test-aperture |
Starting a new snapshot build. You can view the logs here. |
@dandel10n Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
bcf9654
to
8154537
Compare
…-modal - removes pie-design-tokens from pie-cookie-banner dev deps
8154537
to
2a22a8f
Compare
/snapit |
Starting a new snapshot build. You can view the logs here. |
@dandel10n Your snapshots have been published to npm! Test the snapshots by updating your Note If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts. yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile yarn up @justeattakeaway/[email protected] --mode=update-lockfile Then finally: yarn install |
Describe your changes (can list changeset entries if preferable)
"wc-vanilla": minor
"pie-storybook": minor
"pie-docs": minor
"pie-monorepo": minor
[Changed] - pie-design-tokens version bump to 6.5.0.
"@justeattakeaway/pie-css": minor
[Changed] - replaces hardcoded breakpoint values with PIE tokens.
"@justeattakeaway/pie-cookie-banner": patch
[Removed] - pie-design-tokens dependency.
"@justeattakeaway/pie-notification": minor
"@justeattakeaway/pie-modal": minor
[Changed] - replaces media with include-media with pie breakpoints tokens.
It also updates the usage of scss var for ::backdrop in modal component with css value since the bug has been fixed. I still had to leave the old scss option for Safari <v17.6 temporary until we drop the support of v16.
I checked in Browserstack the following browsers:
Firefox: 130, 129, 128
Chrome: 128, 127, 126
Opera: 113, 112, 111
Edge: 128, 127, 126
Safari: 17.6 worked fine on my machine but didn't show the backdrop in browserstack on older versions.
Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR preview/snapit
functionality to test my changes in a consuming applicationReviewer checklists (complete before approving)
Reviewer 1 @kevinrodrigues
PIE Storybook
/PIE Docs
PR previewReviewer 2 @maledr5
PIE Storybook
/PIE Docs
PR preview