[bifrost] Get a CommitToken back from notify_committed()
#3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2025
muhamadazmy
force-pushed
the
pr3968
branch
2 times, most recently
from
238e9a8 to
4d03d85
Compare
muhamadazmy
force-pushed
the
pr3968
branch
6 times, most recently
from
bcf7715 to
eacea80
Compare
This was referenced Nov 13, 2025
muhamadazmy
force-pushed
the
pr3968
branch
4 times, most recently
from
7ed1a07 to
45a2b31
Compare
AhmedSoliman
approved these changes
Nov 17, 2025
Contributor
AhmedSoliman
left a comment
AhmedSoliman
left a comment
There was a problem hiding this comment.
I like this one better. Thanks for making the API more uniform.
| /// Not cancellation safe. Every call will attempt to acquire capacity on the channel and send | ||
| /// a new message to the appender. | ||
| pub async fn notify_committed(&self) -> Result<(), EnqueueError<()>> { | ||
| pub async fn notify_committed(&self) -> Result<CommitToken, EnqueueError<()>> { |
Contributor
There was a problem hiding this comment.
Maybe update the docs to reflect the new contract.
muhamadazmy
force-pushed
the
pr3968
branch
18 times, most recently
from
03cf056 to
eeb457f
Compare
muhamadazmy
force-pushed
the
pr3968
branch
6 times, most recently
from
9780007 to
19f4b7a
Compare
- `ingestion-client` implements the runtime layer that receives WAL envelopes, fans it out to the correct partition, and tracks completion. It exposes: - `IngestionClient`, enforces inflight budgets, and resolves partition IDs before sending work downstream. - The session subsystem that batches `IngestRecords`, retries connections, and reports commit status to callers. - `ingestion-client` only ingests records and notify the caller once the record is "committed" to bifrost by the PP. This makes it useful to implement kafka ingress and other external ingestion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bifrost] Get a
CommitTokenback from notify_committed()Stack created with Sapling. Best reviewed with ReviewStack.
Shuffler#4024IngestionClientfor invocation and state mgmt #3980ingestion-client#3975IngestRequestmessage #3974CommitTokenback from notify_committed() #3968ingestion-clientcrate #3976