[AdminAPI] Use `IngestionClient` for invocation and state mgmt #3980

muhamadazmy · 2025-11-13T12:23:49Z

[AdminAPI] Use IngestionClient for invocation and state mgmt

Use IngestionClient instead of bifrost to write to partitions logs
Remove deprecated delete_invocation

Stack created with Sapling. Best reviewed with ReviewStack.

tillrohrmann

Thanks for creating this PR @muhamadazmy. The changes look good to me :-)

I left a comment about the removal of the "delete an invocation" API. I think it is ok to remove the API since it was deprecated in v1.4.0 but we need to make sure that it's communicated as part of the release. The Admin API version might have to be bumped if older clients could still call the old invocation deletion API.

tillrohrmann · 2025-11-25T21:39:37Z

crates/admin/src/rest_api/invocations.rs

-/// Terminate an invocation
-#[openapi(
-    summary = "Delete an invocation",
-    deprecated = true,


This API was deprecated in 1.4.0. If we remove it with 1.6.0, then we certainly need to add a release note to make people aware. Additionally, we need to check

restate/crates/admin-rest-model/src/version.rs

Line 29 in b9b8f28

V2 = 2,

and

restate/crates/admin/src/rest_api/version.rs

Line 21 in b9b8f28

/// Version information endpoint

whether we need to remove support for AdminApiVersion::V2 because we removed the old delete invocation endpoint. We should then also update

restate/cli/src/clients/admin_client.rs

Line 34 in b9b8f28

pub const MIN_ADMIN_API_VERSION: AdminApiVersion = AdminApiVersion::V2;

accordingly if a bump is needed.

cc @slinkydeveloper for double checking whether we can remove this API.

I actually discussed this with him before I remove it. I was confused because the was 2 endpoints to delete an invocation. So he confirmed that it's no longer used (same for the UI).

Regarding the version, thank you for pointing this out. I think we should indeed set the MIN_ADMIN_API_VERSION to V3

tillrohrmann · 2025-11-25T21:51:55Z

crates/admin/src/rest_api/services.rs

+            warn!("Could not append state patching command to Bifrost: {err}");
+            MetaApiError::Internal(
+                "Failed sending state patching command to the cluster.".to_owned(),


Is this always true that the patch command could not be appended to Bifrost? What if the ingress is closing after having sent the command out?

tillrohrmann · 2025-11-26T08:33:05Z

crates/admin/src/rest_api/services.rs

+    let result = state
+        .ingress
+        .ingest(
+            partition_key,
+            IngestRecord::from_parts(envelope.record_keys(), envelope),
+        )
+        .await


What about rolling upgrades when there are still a few nodes that don't support the PartitionLeaderService yet?

I think we can release all the changes up to kafka ingestion. Then release admin and shuffle changes in the following release.

tillrohrmann

Thanks for updating this PR @muhamadazmy. LGTM. +1 for merging :-)

tillrohrmann · 2025-12-05T16:27:06Z

crates/admin/src/rest_api/version.rs


 /// Min/max supported admin api versions by the server
-pub const MIN_ADMIN_API_VERSION: AdminApiVersion = AdminApiVersion::V2;
+pub const MIN_ADMIN_API_VERSION: AdminApiVersion = AdminApiVersion::V3;


Maybe add a comment why we bumped the min admin version to V3 and in which Restate version this happened.

Does this mean that V2 contained the old kill/cancel invocation endpoint and V3 does not? Maybe we can document what was included/changed with AdminApiVersion::V3 for our future selves.

- Use IngestionClient instead of bifrost to write to partitions logs - Remove deprecated `delete_invocation`

This was referenced Nov 13, 2025

[bifrost] Get a CommitToken back from notify_committed() #3968

Merged

[Ingress-Kafka] Refactor to use ingestion-client #3975

Merged

[Ingestion] ingestion-client crate #3976

Merged

[PP] Handle IngestRequest message #3974

Merged

muhamadazmy force-pushed the pr3980 branch 2 times, most recently from 6fbd35c to 1b6c108 Compare November 13, 2025 13:06

muhamadazmy mentioned this pull request Nov 13, 2025

Ensure Partition Processor Leader Is the Sole Log Writer (for vqueues support) #3965

Closed

5 tasks

muhamadazmy requested a review from tillrohrmann November 14, 2025 10:14

muhamadazmy mentioned this pull request Nov 14, 2025

[Cleaner] remove the cleaner external bifrost writer #3987

Merged

muhamadazmy force-pushed the pr3980 branch 7 times, most recently from 3769517 to a25372c Compare November 17, 2025 12:02

muhamadazmy mentioned this pull request Nov 17, 2025

Use ingestion-client in the Shuffler #4024

Merged

muhamadazmy force-pushed the pr3980 branch 2 times, most recently from 960bebd to 4a40737 Compare November 25, 2025 12:54

tillrohrmann reviewed Nov 25, 2025

View reviewed changes

tillrohrmann reviewed Nov 26, 2025

View reviewed changes

muhamadazmy force-pushed the pr3980 branch 9 times, most recently from 6dccbcf to e58f21d Compare November 28, 2025 16:34

tillrohrmann approved these changes Dec 5, 2025

View reviewed changes

muhamadazmy force-pushed the pr3980 branch 10 times, most recently from b26b442 to bbbb04e Compare December 11, 2025 08:43

muhamadazmy force-pushed the pr3980 branch 2 times, most recently from 425fe18 to 0880a6a Compare December 17, 2025 11:38

muhamadazmy mentioned this pull request Dec 17, 2025

[Ingest] Use bilrost encoding for ingestion message #4113

Merged

muhamadazmy force-pushed the pr3980 branch 6 times, most recently from 715b672 to be1e987 Compare December 19, 2025 10:22

muhamadazmy force-pushed the pr3980 branch 2 times, most recently from ee02391 to bd521a9 Compare December 29, 2025 13:02

muhamadazmy force-pushed the pr3980 branch 3 times, most recently from accb0d0 to fb4f547 Compare January 6, 2026 09:06

[AdminAPI] Use IngestionClient for invocation and state mgmt

b648647

- Use IngestionClient instead of bifrost to write to partitions logs - Remove deprecated `delete_invocation`

muhamadazmy force-pushed the pr3980 branch from fb4f547 to b648647 Compare January 6, 2026 09:41

muhamadazmy merged commit 6794a87 into restatedev:main Jan 6, 2026
58 checks passed

muhamadazmy deleted the pr3980 branch January 6, 2026 10:11

github-actions bot locked and limited conversation to collaborators Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AdminAPI] Use `IngestionClient` for invocation and state mgmt #3980

[AdminAPI] Use `IngestionClient` for invocation and state mgmt #3980

Uh oh!

muhamadazmy commented Nov 13, 2025 •

edited

Loading

Uh oh!

tillrohrmann left a comment

Uh oh!

tillrohrmann Nov 25, 2025

Uh oh!

tillrohrmann Nov 25, 2025

Uh oh!

muhamadazmy Dec 1, 2025

Uh oh!

tillrohrmann Nov 25, 2025

Uh oh!

tillrohrmann Nov 26, 2025

Uh oh!

muhamadazmy Dec 2, 2025

Uh oh!

tillrohrmann left a comment

Uh oh!

tillrohrmann Dec 5, 2025

Uh oh!

tillrohrmann Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[AdminAPI] Use IngestionClient for invocation and state mgmt #3980

[AdminAPI] Use IngestionClient for invocation and state mgmt #3980

Uh oh!

Conversation

muhamadazmy commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tillrohrmann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tillrohrmann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[AdminAPI] Use `IngestionClient` for invocation and state mgmt #3980

[AdminAPI] Use `IngestionClient` for invocation and state mgmt #3980

muhamadazmy commented Nov 13, 2025 •

edited

Loading