[Cleaner] remove the cleaner external bifrost writer #3987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2025
muhamadazmy
force-pushed
the
pr3987
branch
4 times, most recently
from
7c63aa8 to
f21eef3
Compare
5 tasks
muhamadazmy
force-pushed
the
pr3987
branch
3 times, most recently
from
1ec113e to
cec1475
Compare
muhamadazmy
force-pushed
the
pr3987
branch
3 times, most recently
from
6e4eac3 to
13c995f
Compare
tillrohrmann
approved these changes
Nov 25, 2025
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for removing the external bifrost writer from the cleaner task @muhamadazmy. The changes look good to me. Did you see any negative impact on the partition processor loop by these changes? If not, then +1 for merging :-)
Contributor
Author
|
@tillrohrmann I ran few tests with very aggressive cleanup timer (and very short retention periods) and I did not observe any regression in performance compared to main. |
muhamadazmy
force-pushed
the
pr3987
branch
10 times, most recently
from
c41ecb6 to
11e5095
Compare
muhamadazmy
force-pushed
the
pr3987
branch
10 times, most recently
from
af82da1 to
8b37c97
Compare
tillrohrmann
approved these changes
Dec 5, 2025
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
LGTM. +1 for merging :-)
muhamadazmy
force-pushed
the
pr3987
branch
10 times, most recently
from
faf9958 to
eaccc70
Compare
muhamadazmy
force-pushed
the
pr3987
branch
2 times, most recently
from
bb244b9 to
384853c
Compare
Summary: Switch to bilrost encoding
Summary: This PR makes sure cleaner does not do an external bifrost write by using creating a cleaner effect stream that can be handled directly by the PP event loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Cleaner] remove the cleaner external bifrost writer
Summary:
This PR makes sure cleaner does not do an external bifrost write
by using creating a cleaner effect stream that can be handled
directly by the PP event loop
Stack created with Sapling. Best reviewed with ReviewStack.
Shuffler#4024IngestionClientfor invocation and state mgmt #3980ingestion-client#3975