Skip to content

Conversation

Timple
Copy link
Contributor

@Timple Timple commented May 23, 2025

Going from:

Report stale as errors unless all stale

to:

If one STALE and no ERROR, report STALE

As a bonus, the message that caused the degradation of the diagnostics is added to the toplevel state. This is useful for reporting mechanisms such as error logs.

@mergify mergify bot added the ros2 PR tackling a ROS2 branch label May 23, 2025
@Timple Timple force-pushed the feature/report-stale-if-one-stale branch from f9b78c0 to 8cd4d07 Compare May 26, 2025 07:42
@Timple
Copy link
Contributor Author

Timple commented May 26, 2025

Rebased as build failed on #507

@ct2034 ct2034 added the enhancement This tackles a new feature of the code (and not a bug) label May 26, 2025
@Timple
Copy link
Contributor Author

Timple commented Jun 30, 2025

Any objections here?

We think it makes more sense to report STALE as summary. Because now you can have an ERROR without any actual ERROR states.

@Timple
Copy link
Contributor Author

Timple commented Aug 15, 2025

If there are any reasons not to do this, we'd also like to hear. Or should this pass an MPC or something?

@Timple Timple force-pushed the feature/report-stale-if-one-stale branch from 8cd4d07 to 601b4a6 Compare August 15, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This tackles a new feature of the code (and not a bug) ros2 PR tackling a ROS2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants