Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings to close method in PyReader and PyCompressionReader (#1934) #1935

Merged
merged 1 commit into from
Mar 12, 2025
+4 −0
Merged

Add bindings to close method in PyReader and PyCompressionReader (#1934) #1935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rosbag2_py/rosbag2_py/_reader.pyi
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
class SequentialCompressionReader:
def __init__(self) -> None: ...
def close(self) -> None: ...
def get_all_message_definitions(self, *args, **kwargs): ...
def get_all_topics_and_types(self, *args, **kwargs): ...
def get_metadata(self, *args, **kwargs): ...
@@ -14,6 +15,7 @@ class SequentialCompressionReader:

class SequentialReader:
def __init__(self) -> None: ...
def close(self) -> None: ...
def get_all_message_definitions(self, *args, **kwargs): ...
def get_all_topics_and_types(self, *args, **kwargs): ...
def get_metadata(self, *args, **kwargs): ...
2 changes: 2 additions & 0 deletions rosbag2_py/src/rosbag2_py/_reader.cpp
View file
Original file line number Diff line number Diff line change
@@ -86,6 +86,7 @@ PYBIND11_MODULE(_reader, m) {
pybind11::overload_cast<
const rosbag2_storage::StorageOptions &, const rosbag2_cpp::ConverterOptions &
>(&PyReader::open))
.def("close", &PyReader::close)
.def("set_read_order", &PyReader::set_read_order)
.def("read_next", &PyReader::read_next)
.def("has_next", &PyReader::has_next)
@@ -109,6 +110,7 @@ PYBIND11_MODULE(_reader, m) {
pybind11::overload_cast<
const rosbag2_storage::StorageOptions &, const rosbag2_cpp::ConverterOptions &
>(&PyCompressionReader::open))
.def("close", &PyCompressionReader::close)
.def("set_read_order", &PyCompressionReader::set_read_order)
.def("read_next", &PyCompressionReader::read_next)
.def("has_next", &PyCompressionReader::has_next)