Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings to close method in PyReader and PyCompressionReader (#1934) #1935

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Add bindings to close method in PyReader and PyCompressionReader (#1934) #1935

merged 1 commit into from
Mar 12, 2025

Conversation

oysstu
Copy link
Contributor

@oysstu oysstu commented Mar 11, 2025 •
edited
Loading

Adds bindings to the close method through pybind11. Reported in issue #1934.

fujitatomoya
fujitatomoya approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. looks like this one was just missing.

MichaelOrlov
MichaelOrlov approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fujitatomoya
Copy link
Contributor

fujitatomoya commented Mar 11, 2025 •
edited by christophebedard
Loading

Pulls: #1935
Gist: https://gist.githubusercontent.com/fujitatomoya/5db7dcdefbe79fafece5115b6a59a95b/raw/dbeb01b38a3fea1fcdba8803c8e40f277f5c4a91/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py
TEST args: --packages-above rosbag2_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15343

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

I retriggered the Windows job since there was a remote connection issue.

@ahcorde
Copy link
Contributor

ahcorde commented Mar 12, 2025

windows warning is unrelated

@ahcorde ahcorde merged commit d3cb4e3 into ros2:rolling Mar 12, 2025
12 checks passed
@oysstu oysstu mentioned this pull request Mar 12, 2025
Closed
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Mar 12, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@oysstu @mergify
Add bindings to close method in PyReader and PyCompressionReader (#1935)
0ca490e 
Signed-off-by: Øystein Sture <[email protected]>
(cherry picked from commit d3cb4e3)
@mergify mergify bot mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oysstu @fujitatomoya @christophebedard @ahcorde @MichaelOrlov