Skip to content

Run RMW tests in isolation and call shutdown on error - #2460

Merged
ahcorde merged 1 commit into
rollingfrom
yadu/fix-test-isolation
Jul 23, 2026
Merged

Run RMW tests in isolation and call shutdown on error#2460
ahcorde merged 1 commit into
rollingfrom
yadu/fix-test-isolation

Conversation

@Yadunund

Copy link
Copy Markdown
Member

Description

Addresses parts of # ros2/rmw_zenoh#1016

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes, Claude Opus 4.8 to identify which tests need to be updated.

Additional Information

Signed-off-by: Yadunund Vijay <yadunund@gmail.com>
@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ahcorde

ahcorde commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Pulls: #2460
Gist: https://gist.githubusercontent.com/ahcorde/4f01257a349fc0afbb7c67f3657c886e/raw/3f5f4d82d7bcaef6f5df42d9670bfbcb0d40f840/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py rosbag2_tests
TEST args: --packages-above rosbag2_py rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19942

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
ahcorde merged commit 2777970 into rolling Jul 23, 2026
12 checks passed
@ahcorde
ahcorde deleted the yadu/fix-test-isolation branch July 23, 2026 16:25
@ahcorde

ahcorde commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

https://github.com/Mergifyio backport lyrical kilted

@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown

backport lyrical kilted

✅ Backports have been created

Details

Cherry-pick of 2777970 has failed:

On branch mergify/bp/kilted/pr-2460
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 2777970.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rosbag2_py/CMakeLists.txt
	modified:   rosbag2_tests/CMakeLists.txt
	modified:   rosbag2_tests/package.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_py/src/rosbag2_py/_transport.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants