Fix for spatial_neighbors breaks when transform='spectral'

[selmanozleyen]

Fixes #1014

[selmanozleyen]

thanks for the feedback but fau doesn't work with python 3.10.

[selmanozleyen]

@Intron7 should I merge this branch?

[flying-sheep]

looks good to me, but @Intron7 should check if it works in his example.

[codecov]

Codecov Report

❌ Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (f11e20f) to head (a131158).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/squidpy/gr/_build.py	64.70%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   66.47%   66.60%   +0.13%     
==========================================
  Files          45       45              
  Lines        7015     7017       +2     
  Branches     1184     1185       +1     
==========================================
+ Hits         4663     4674      +11     
+ Misses       1890     1880      -10     
- Partials      462      463       +1     

Files with missing lines	Coverage Δ
src/squidpy/gr/_build.py	88.47% <64.70%> (+3.83%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Intron7]

why np.float64?

[selmanozleyen]

because original function used np.float64. Didn't want to change old behaviour

[Intron7]

can we check if this is needed

[selmanozleyen]

well I can't tell tbh because there was no tests for the spectral transform lol. We can just use float32 I guess. But the better way would be to ask ths users of spatial_neighbours

[selmanozleyen]

@Intron7 ok the results seem similar when I checked them. I also added some numerical tests to ensure stability. Also when I recalled that this was just a normalization of weights in a graph so it should not be very sensitive to precision in theory.

[selmanozleyen]

@timtreis could you merge this please? @Intron7 said he can't review it and @flying-sheep already had a look on this

Implemented