[haproxy] Declare haproxy in the services tuple - #4436
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
setup() calls add_service_status() and add_journal() for the haproxy unit rather than declaring it in the services tuple. Plugin._collect_services() already runs each entry of that tuple through is_service() and calls both, so the explicit calls are redundant. Declaring the unit also gives the plugin an additional enablement trigger. haproxy currently enables on the package or on the puppet-generated config directory, so a host running the service without the package installed locally is missed. haproxy is the only plugin in the tree still using the explicit form for a unit it collects both status and journal for. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup()callsadd_service_status()andadd_journal()for the haproxy unitrather than declaring it in the
servicestuple.Plugin._collect_services()already runs each entry of that tuple throughis_service()and calls both, so the explicit calls are redundant.Declaring the unit also gives the plugin an additional enablement trigger.
haproxy currently enables on the package or on the puppet-generated config
directory, so a host running the service without the package installed locally
is missed.
haproxy is the only plugin in the tree still using the explicit form for a unit
it collects both status and journal for.
This follows @TurboTurtle's review comment on #4429.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines