Skip to content

[haproxy] Declare haproxy in the services tuple - #4436

Open
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:haproxy-services-tuple
Open

[haproxy] Declare haproxy in the services tuple#4436
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:haproxy-services-tuple

Conversation

@suraj-cmd

Copy link
Copy Markdown
Contributor

setup() calls add_service_status() and add_journal() for the haproxy unit
rather than declaring it in the services tuple.
Plugin._collect_services() already runs each entry of that tuple through
is_service() and calls both, so the explicit calls are redundant.

Declaring the unit also gives the plugin an additional enablement trigger.
haproxy currently enables on the package or on the puppet-generated config
directory, so a host running the service without the package installed locally
is missed.

haproxy is the only plugin in the tree still using the explicit form for a unit
it collects both status and journal for.

This follows @TurboTurtle's review comment on #4429.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords

setup() calls add_service_status() and add_journal() for the
haproxy unit rather than declaring it in the services tuple.
Plugin._collect_services() already runs each entry of that tuple
through is_service() and calls both, so the explicit calls are
redundant.

Declaring the unit also gives the plugin an additional
enablement trigger. haproxy currently enables on the package or
on the puppet-generated config directory, so a host running the
service without the package installed locally is missed.

haproxy is the only plugin in the tree still using the explicit
form for a unit it collects both status and journal for.

Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4436
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant