feat(keycard): Add support for keycard channel events #19548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjba
requested review from
Khushboo-dev-cpp,
caybro,
iurimatias,
micieslak and
saledjenic
and removed request for
a team and
iurimatias
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19548#1 🔹 ~14 min 🔹 86711e0 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-desktop/e2e/prspr19548 🔹 ~17 min 🔹 86711e0 🔹 📦 tests/e2e package |
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
39ed060 to
d281472
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
86711e0 to
e71a2fa
Compare
Member
Member
Member
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19548#2 🔹 ~29 min 🔹 e71a2fa 🔹 📦 tests/ui package |
Member
Member
Member
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
d281472 to
e64335b
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e71a2fa to
adabada
Compare
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
e64335b to
92e99e9
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
adabada to
cd46a72
Compare
Member
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19548#3 🔹 ~24 min 🔹 cd46a72 🔹 📦 tests/nim package |
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
92e99e9 to
397f697
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
cd46a72 to
bcf9a24
Compare
saledjenic
approved these changes
Dec 11, 2025
| if jsonSignal["type"].getStr == "status-changed": | ||
| let signalType = jsonSignal["type"].getStr | ||
|
|
||
| if signalType == "status-changed": |
Contributor
There was a problem hiding this comment.
Maybe we can add "status-changed" and "channel-state-changed" to app_service/common/wallet_constants.nim?
Member
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19548#4 🔹 ~23 min 🔹 bcf9a24 🔹 📦 tests/nim package |
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19548#4 🔹 ~31 min 🔹 bcf9a24 🔹 📦 tests/ui package |
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
397f697 to
41159d3
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
bcf9a24 to
aab486b
Compare
Member
Jenkins BuildsClick to see older builds (35)
|
caybro
reviewed
Dec 22, 2025
| notify = keycardChannelStateChanged | ||
|
|
||
| # Constants for channel states (readonly properties for QML) | ||
| proc getStateIdle*(self: View): string {.slot.} = |
Member
There was a problem hiding this comment.
These read-only constant properties could go to some QML enums, wdyt? Unless you really need them on the NIM side as well
Contributor
Author
There was a problem hiding this comment.
Makes sense. I'll update the following PR where I'm actually using these constants.
alexjba
force-pushed
the
fix/keycard-nfc-2
branch
from
41159d3 to
d606f25
Compare
The keycard channel events will inform the app of the channel state (waiting for keycard, reading, error, idle). This will be used on mobile platforms to control a drawer that informs the user when it's required to tap the keycard.
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
aab486b to
668b750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterates #19545
The keycard channel events will inform the app of the channel state (waiting for keycard, reading, error, idle). This will be used on mobile platforms to control a drawer that informs the user when it's required to tap the keycard.
status-keycard-qt adds these new events driven by the channel state.
NOTE: Tests can be done in the final PR #19549