feat(Keycard): Adding a keycard info drawer for Android to guide the keycard interactions #19549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#1 🔹 ~19 min 🔹 23b6c55 🔹 📦 tests/ui package |
Member
Member
Member
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
86711e0 to
e71a2fa
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
23b6c55 to
7515f6e
Compare
Member
Member
alexjba
requested review from
a team,
caybro,
micieslak and
noeliaSD
as code owners
Member
Member
✔️ status-desktop/prs/linux/x86_64/tests-ui/PR-19549#2 🔹 ~37 min 🔹 7515f6e 🔹 📦 tests/ui package |
Member
Member
Member
✔️ status-desktop/e2e/prspr19549 🔹 ~17 min 🔹 7515f6e 🔹 📦 tests/e2e package |
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
e71a2fa to
adabada
Compare
alexjba
requested review from
friofry and
vkjr
and removed request for
a team
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
7515f6e to
0561ebc
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
adabada to
cd46a72
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
0561ebc to
ff70aed
Compare
Member
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
cd46a72 to
bcf9a24
Compare
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
ff70aed to
240efa3
Compare
saledjenic
approved these changes
Dec 11, 2025
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#4 🔹 ~32 min 🔹 240efa3 🔹 📦 tests/nim package |
Member
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#4 🔹 ~38 min 🔹 240efa3 🔹 📦 tests/ui package |
Member
Member
Member
Member
✔️ status-app/prs/linux/x86_64/tests-nim/PR-19549#5 🔹 ~44 min 🔹 b1b5809 🔹 📦 tests/nim package |
Member
✔️ status-app/prs/linux/x86_64/tests-ui/PR-19549#5 🔹 ~50 min 🔹 b1b5809 🔹 📦 tests/ui package |
Member
Contributor
|
Hi @alexjba , tried on Moto G55, Android 14. During onboarding flow (create with empty keycard) it consistently ends up on "Smartcard reader service unavailable" after "reading card" is shown in the drawer. In the logs I can see it go from tag discovered view logcat (message:nfc) and screenshot
|
Contributor
|
Tried Samsung A36, Android 15. Got further than the Moto but there appears to be a regression in backup seed phrase stage of onboarding, the phrase is not revealed. Then it got stuck on "Creating key pair on Keycard" screen. Screenshots on first attempt
Attempted closing app and retrying but got stuck at the initial "insert your keycard" stage logcat on second attempt (message:nfc)... 
|
caybro
reviewed
Dec 17, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Nice work but some suggestions
| } | ||
|
|
||
| // Error state | ||
| KeycardStateDisplay { |
Member
There was a problem hiding this comment.
All these KeycardStateDisplay QML elements could be just one, and proper QML States could be used to just change the iconSource, title or description properties
Member
There was a problem hiding this comment.
As @caybro suggested, or alternatively some inline component to avoid repeating fixed part as the behavior on opacity. Hmm, state machine approach won't give the effect of opacity-based transition, right?
Contributor
Author
There was a problem hiding this comment.
I've moved the state queue logic to a new component and simplified the drawer. Now it only has a single KeycardStateDisplay with a few states driven by KeycardChannelStateManager. The qtqml state machine doesn't seem to help much. 90% of the logic is related to holding a backend state queue and do some state translations (the backend changes states very fast - and this queue will make sure the user has some time to see the transitions)
| // INTERNAL STATE MANAGEMENT - Queue-based approach | ||
| // ============================================================ | ||
|
|
||
| QtObject { |
Member
There was a problem hiding this comment.
I feel like this whole state machine could be a proper one (https://doc.qt.io/qt-6/qml-qtqml-statemachine-statemachine.html), but definitely not here inside a StatusDialog, wdyt?
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
bcf9a24 to
aab486b
Compare
alexjba
force-pushed
the
fix/keycard-nfc-3
branch
from
aab486b to
668b750
Compare
…keycard interactions Adding a `KeycardChannelDrawer` that's guiding the user whenever the keycard is needed. On IOS the system drawer is used
…ponents - use a single KeycardStateDisplay instance with the necessary states - The state queue, transitions and entire logic moved to KeycardChannelStateManager component
The constants are moved from nim to qml
alexjba
force-pushed
the
fix/keycard-nfc-4
branch
from
b1b5809 to
1daf137
Compare
alexjba
commented
Dec 22, 2025
| InProgress, | ||
| Completed | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
re: #19548 (comment)
@caybro Moved it here, in qml
Member
Jenkins BuildsClick to see older builds (31)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Iterating
#19545
#19546
#19547
#19548
Adding a
KeycardChannelDrawerthat's guiding the user whenever the keycard is needed.On IOS the system drawer is used.
Screencapture of the functionality
Screen_Recording_20251210_154214_Status.mp4
ScreenRecording_12-10-2025.17-21-13_1.MP4
Screen.Recording.2025-12-10.at.15.11.49.mov
Impact on end user
How to test
desktop:
make run USE_STATUS_KEYCARD_QT=1iOS:
make mobile-run USE_STATUS_KEYCARD_QT=1 DEVELOPMENT_TEAM=...android:
make mobile-run