Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade packages to latest, especially @typescript-eslint versions to 8.18.0 #15

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: upgrade packages to latest, especially @typescript-eslint versions to 8.18.0 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426809c
upgrade versions fix #14
baruchiro Dec 11, 2024
a10bdbc
Bump remaining packages to latest, and add noEmit: true
JoshuaKGoldberg Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,473 changes: 1,792 additions & 1,681 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/eslint-plugin-example-typed-linting/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import tseslint from 'typescript-eslint';
export default tseslint.config(
{ ignores: ["lib"] },
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
tseslint.configs.recommendedTypeChecked,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the latest versions, the ... is no longer necessary. Arbitrary nesting is now allowed.

exampleTypedLinting.configs.recommended // 👈
{
languageOptions: {
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-example-typed-linting/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import tseslint from 'typescript-eslint';
export default tseslint.config(
{ ignores: ["lib"] },
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
tseslint.configs.recommendedTypeChecked,
eslintPlugin.configs['flat/recommended'],
{
languageOptions: {
Expand Down
22 changes: 11 additions & 11 deletions packages/eslint-plugin-example-typed-linting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"dependencies": {
"@typescript-eslint/utils": "8.0.0-alpha.59"
"@typescript-eslint/utils": "8.18.0"
},
"devDependencies": {
"@eslint/js": "^9.8.0",
"@types/eslint": "^9.6.0",
"@eslint/js": "^9.16.0",
"@types/eslint": "^9.6.1",
"@types/eslint__js": "^8.42.3",
"@types/node": "^22.0.2",
"@typescript-eslint/rule-tester": "^8.0.0-alpha.59",
"eslint": "^9.8.0",
"eslint-doc-generator": "^1.7.1",
"eslint-plugin-eslint-plugin": "^6.2.0",
"typescript": "^5.5.4",
"typescript-eslint": "^8.0.0-alpha.59",
"vitest": "^2.0.4"
"@types/node": "^22.10.2",
"@typescript-eslint/rule-tester": "8.18.0",
"eslint": "^9.16.0",
"eslint-doc-generator": "^2.0.0",
"eslint-plugin-eslint-plugin": "^6.3.2",
"typescript": "^5.7.2",
"typescript-eslint": "8.18.0",
"vitest": "^2.1.8"
},
"exports": {
".": {
Expand Down
4 changes: 2 additions & 2 deletions packages/flat-config-disable-type-checked/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const unused = true;

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
tseslint.configs.recommendedTypeChecked,
{
languageOptions: {
parserOptions: {
Expand All @@ -16,7 +16,7 @@ export default tseslint.config(
},
},
{
extends: [tseslint.configs.disableTypeChecked],
files: ["*.js"],
...tseslint.configs.disableTypeChecked,
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tseslint.config's extends actually always worked this way, I'd just not gotten in the habit of using it nicely.

}
);
8 changes: 4 additions & 4 deletions packages/flat-config-disable-type-checked/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
},
"license": "MIT",
"devDependencies": {
"@types/eslint": "^8.56.2",
"eslint": "^8.56.0",
"typescript": "^5.3.3",
"typescript-eslint": "^7.0.1"
"@types/eslint": "^9.6.1",
"eslint": "^9.16.0",
"typescript": "^5.7.2",
"typescript-eslint": "^8.18.0"
},
"scripts": {
"lint": "eslint .",
Expand Down
1 change: 1 addition & 0 deletions packages/flat-config-disable-type-checked/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext",
"noEmit": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been on before, so that if you ran npm run tsc before npm run lint you wouldn't have extra src/*.js files to lint.

"strict": true
},
"include": ["src"]
Expand Down
2 changes: 1 addition & 1 deletion packages/flat-config-typed-tsconfig/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export async function unecessarilyAsync() {

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
tseslint.configs.recommendedTypeChecked,
{
languageOptions: {
parserOptions: {
Expand Down
8 changes: 4 additions & 4 deletions packages/flat-config-typed-tsconfig/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
},
"license": "MIT",
"devDependencies": {
"@types/eslint": "^8.56.2",
"@types/eslint": "^9.6.1",
"@types/eslint__js": "^8.42.3",
"eslint": "^8.56.0",
"typescript": "^5.3.3",
"typescript-eslint": "^7.0.1"
"eslint": "^9.16.0",
"typescript": "^5.7.2",
"typescript-eslint": "^8.18.0"
},
"scripts": {
"lint": "eslint .",
Expand Down
3 changes: 1 addition & 2 deletions packages/flat-config-typed-tsconfig/tsconfig.eslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"allowJs": true,
"noEmit": true
"allowJs": true
},
"include": ["."]
}
1 change: 1 addition & 0 deletions packages/flat-config-typed-tsconfig/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext",
"noEmit": true,
"strict": true
},
"include": ["src"]
Expand Down
2 changes: 1 addition & 1 deletion packages/flat-config-typed/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import tseslint from "typescript-eslint";

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
tseslint.configs.recommendedTypeChecked,
{
languageOptions: {
parserOptions: {
Expand Down
8 changes: 4 additions & 4 deletions packages/flat-config-typed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
},
"license": "MIT",
"devDependencies": {
"@types/eslint": "^8.56.2",
"eslint": "^8.56.0",
"typescript": "^5.3.3",
"typescript-eslint": "^7.0.1"
"@types/eslint": "^9.6.1",
"eslint": "^9.16.0",
"typescript": "^5.7.2",
"typescript-eslint": "^8.18.0"
},
"scripts": {
"lint": "eslint src",
Expand Down
2 changes: 1 addition & 1 deletion packages/flat-config-untyped/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ import tseslint from "typescript-eslint";

export default tseslint.config(
eslint.configs.recommended,
...tseslint.configs.recommended
tseslint.configs.recommended
);
6 changes: 3 additions & 3 deletions packages/flat-config-untyped/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
},
"license": "MIT",
"devDependencies": {
"typescript-eslint": "^7.0.1",
"typescript": "^5.3.3",
"eslint": "^8.56.0"
"typescript-eslint": "^8.18.0",
"typescript": "^5.7.2",
"eslint": "^9.16.0"
},
"scripts": {
"lint": "eslint src",
Expand Down
1 change: 1 addition & 0 deletions packages/flat-config-untyped/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext",
"noEmit": true,
"strict": true
},
"include": ["src"]
Expand Down
12 changes: 6 additions & 6 deletions packages/typed-rule-via-linter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
},
"license": "MIT",
"dependencies": {
"@typescript-eslint/parser": "^6.19.1",
"@typescript-eslint/utils": "^6.19.1",
"eslint": "^8.56.0",
"typescript": "^5.3.3"
"@typescript-eslint/parser": "^8.18.0",
"@typescript-eslint/utils": "^8.18.0",
"eslint": "^9.16.0",
"typescript": "^5.7.2"
},
"devDependencies": {
"@types/eslint": "^8.56.2",
"tsx": "^4.7.0"
"@types/eslint": "^9.6.1",
"tsx": "^4.19.2"
},
"scripts": {
"example": "tsx index.ts"
Expand Down
10 changes: 5 additions & 5 deletions packages/typescript-estree-standalone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
},
"license": "MIT",
"dependencies": {
"@typescript-eslint/typescript-estree": "^6.19.1",
"ts-api-utils": "^1.0.3",
"typescript": "^5.3.3"
"@typescript-eslint/typescript-estree": "^8.18.0",
"ts-api-utils": "^2.0.0",
"typescript": "^5.7.2"
},
"devDependencies": {
"@types/node": "^20.11.6",
"tsx": "^4.7.0"
"@types/node": "^22.10.2",
"tsx": "^4.19.2"
},
"scripts": {
"example": "tsx index.ts"
Expand Down