fix: upgrade packages to latest, especially @typescript-eslint versions to 8.18.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Dec 11, 2024
JoshuaKGoldberg
changed the title
| @@ -13,7 +13,7 @@ import tseslint from 'typescript-eslint'; | |||
| export default tseslint.config( | |||
| { ignores: ["lib"] }, | |||
| eslint.configs.recommended, | |||
| ...tseslint.configs.recommendedTypeChecked, | |||
| tseslint.configs.recommendedTypeChecked, | |||
There was a problem hiding this comment.
In the latest versions, the ... is no longer necessary. Arbitrary nesting is now allowed.
| files: ["*.js"], | ||
| ...tseslint.configs.disableTypeChecked, |
There was a problem hiding this comment.
tseslint.config's extends actually always worked this way, I'd just not gotten in the habit of using it nicely.
| @@ -2,6 +2,7 @@ | |||
| "compilerOptions": { | |||
| "module": "NodeNext", | |||
| "moduleResolution": "NodeNext", | |||
| "noEmit": true, | |||
There was a problem hiding this comment.
This should have been on before, so that if you ran npm run tsc before npm run lint you wouldn't have extra src/*.js files to lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade versions to fix #14