refactor github issues fetching #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deniak
commented
Jan 20, 2021
deniak
commented
- refactoring github issues fetching
- cleanup indentation
himorin
reviewed
Jan 20, 2021
| function getAllData (repo, doc) { | ||
| let arr = []; | ||
| for (let p=1; p < maxpages+1; p++) { | ||
| arr.push(fetch('https://api.github.com/repos/w3c/'+repo+'/issues?per_page=100&page='+p)); |
There was a problem hiding this comment.
I suppose we need to check return code and throw custom error, that fetch does not throw error on 403/404 etc.
(also might be better to check maximum number of pages like #855 rather than using fixed number?)
There was a problem hiding this comment.
Indeed, it would be good to check the errors and go through all the pages. In that PR, I was just trying to fix the race condition issue for the snapshot generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.