-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): replace first_stop_path_point_index #9296
feat(behavior_velocity_planner): replace first_stop_path_point_index #9296
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
9e08790
to
462a115
Compare
Signed-off-by: Y.Hisaki <[email protected]>
462a115
to
ca7d4c9
Compare
...ing/behavior_velocity_planner/autoware_behavior_velocity_detection_area_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
...ty_planner/autoware_behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Y.Hisaki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9296 +/- ##
==========================================
- Coverage 29.21% 29.20% -0.02%
==========================================
Files 1335 1339 +4
Lines 102960 103010 +50
Branches 39950 39958 +8
==========================================
Hits 30080 30080
- Misses 70010 70059 +49
- Partials 2870 2871 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
...ning/behavior_velocity_planner/autoware_behavior_velocity_traffic_light_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
…traffic_light_module/src/scene.cpp Co-authored-by: Kosuke Takeuchi <[email protected]>
planning/behavior_velocity_planner/autoware_behavior_velocity_planner/src/planner_manager.cpp
Outdated
Show resolved
Hide resolved
…planner/src/planner_manager.cpp Co-authored-by: Kosuke Takeuchi <[email protected]>
Description
Previously, we stored the first stopping point on the path in the variable
SceneModuleInterface::first_stop_path_point_index_
. However, we plan to replace this with a class that handles paths continuously in the future by using autoware_trajectory. In this case, the current method of directly handling path point indices should be replaced with a method that handles distances from the path's starting point.In this PR, instead of using the variable
SceneModuleInterface::first_stop_path_point_index_
, we now manage the first_stop_path_point using the variableSceneModuleInterface::first_stop_path_point_distance_
.SceneModuleInterface::first_stop_path_point_distance_
represents the distance from the path's starting point.Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.