Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): replace first_stop_path_point_index #9296

Merged

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Nov 12, 2024

Description

Previously, we stored the first stopping point on the path in the variable SceneModuleInterface::first_stop_path_point_index_. However, we plan to replace this with a class that handles paths continuously in the future by using autoware_trajectory. In this case, the current method of directly handling path point indices should be replaced with a method that handles distances from the path's starting point.
In this PR, instead of using the variable SceneModuleInterface::first_stop_path_point_index_, we now manage the first_stop_path_point using the variable SceneModuleInterface::first_stop_path_point_distance_. SceneModuleInterface::first_stop_path_point_distance_ represents the distance from the path's starting point.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki force-pushed the replace-first_stop_path_point_index_ branch from 9e08790 to 462a115 Compare November 12, 2024 10:53
Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 14, 2024
@yhisaki yhisaki enabled auto-merge (squash) November 14, 2024 02:42
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.

Project coverage is 29.20%. Comparing base (8652963) to head (86bb47c).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...topping_area_module/src/scene_no_stopping_area.cpp 0.00% 6 Missing ⚠️
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% 3 Missing ⚠️
...avior_velocity_detection_area_module/src/scene.cpp 60.00% 1 Missing and 1 partial ⚠️
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 2 Missing ⚠️
...vior_velocity_traffic_light_module/src/manager.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9296      +/-   ##
==========================================
- Coverage   29.21%   29.20%   -0.02%     
==========================================
  Files        1335     1339       +4     
  Lines      102960   103010      +50     
  Branches    39950    39958       +8     
==========================================
  Hits        30080    30080              
- Misses      70010    70059      +49     
- Partials     2870     2871       +1     
Flag Coverage Δ *Carryforward flag
differential 21.76% <51.72%> (?)
total 29.20% <ø> (-0.01%) ⬇️ Carriedforward from 7007bc6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

…traffic_light_module/src/scene.cpp

Co-authored-by: Kosuke Takeuchi <[email protected]>
…planner/src/planner_manager.cpp

Co-authored-by: Kosuke Takeuchi <[email protected]>
@yhisaki yhisaki enabled auto-merge (squash) November 14, 2024 08:18
@yhisaki yhisaki merged commit 7528c47 into autowarefoundation:main Nov 14, 2024
31 of 32 checks passed
@yhisaki yhisaki deleted the replace-first_stop_path_point_index_ branch November 14, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants