Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): replace first_stop_path_point_index #9296

Merged

Update planning/behavior_velocity_planner/autoware_behavior_velocity_…

86bb47c
Select commit
Loading
Failed to load commit list.
Merged

feat(behavior_velocity_planner): replace first_stop_path_point_index #9296

Update planning/behavior_velocity_planner/autoware_behavior_velocity_…
86bb47c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 14, 2024 in 46s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.24 -> 9.24)

  • Declining Code Health: 3 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene.cpp: DetectionAreaModule::modifyPathVelocity
  • Complex Method scene_no_stopping_area.cpp: NoStoppingAreaModule::modifyPathVelocity
  • Complex Method scene.cpp: StopLineModule::modifyPathVelocity

Annotations

Check warning on line 205 in planning/behavior_velocity_planner/autoware_behavior_velocity_detection_area_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

DetectionAreaModule::modifyPathVelocity already has high cyclomatic complexity, and now it increases in Lines of Code from 118 to 119. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 163 in planning/behavior_velocity_planner/autoware_behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

NoStoppingAreaModule::modifyPathVelocity already has high cyclomatic complexity, and now it increases in Lines of Code from 99 to 100. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 95 in planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/src/scene.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

StopLineModule::modifyPathVelocity already has high cyclomatic complexity, and now it increases in Lines of Code from 98 to 99. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.