Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): change module initial state to WAITING_APPROVAL #9313

Closed

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Nov 13, 2024

Description

Each initial state of scene module in behavior path planner has been set to RUNNING by the setInitState function: therefore, the state would transfer from IDLE to RUNNING.
From the perspective of state transition, each module should transfer from IDLE to WAITING_APPROVAL.
This PR sets the initial state to WAITING_APPROVAL inside the setInitState.

Related links

None

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 13, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.28%. Comparing base (391beda) to head (bb78262).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...lanner_common/interface/scene_module_interface.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9313      +/-   ##
==========================================
- Coverage   29.29%   29.28%   -0.02%     
==========================================
  Files        1334     1340       +6     
  Lines      102798   102841      +43     
  Branches    39985    39986       +1     
==========================================
  Hits        30119    30119              
- Misses      69811    69854      +43     
  Partials     2868     2868              
Flag Coverage Δ *Carryforward flag
differential 19.49% <0.00%> (?)
total 29.29% <ø> (+<0.01%) ⬆️ Carriedforward from 391beda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori enabled auto-merge (squash) November 13, 2024 13:19
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since LC is already overriding to transit IDLE -> WAITING_APPROVAL -> RUNNING, this is OK.

@go-sakayori go-sakayori marked this pull request as draft November 14, 2024 02:56
@go-sakayori go-sakayori deleted the fix/bpp_init_module_state branch November 14, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants