Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(behavior_path_planner): change module initial state to WAITING_APPROVAL #9313

Closed
wants to merge 2 commits into from
+1 −3
Closed

fix(behavior_path_planner): change module initial state to WAITING_APPROVAL #9313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d759b11
change module initial state
go-sakayori Nov 13, 2024
bb78262
delete setInitState function in lane change module
go-sakayori Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...r_path_lane_change_module/include/autoware/behavior_path_lane_change_module/interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ class LaneChangeInterface : public SceneModuleInterface

bool canTransitFailureState() override;

ModuleStatus setInitState() const override { return ModuleStatus::WAITING_APPROVAL; };

void updateRTCStatus(
const double start_distance, const double finish_distance, const bool safe,
const uint8_t & state)
Expand Down
2 changes: 1 addition & 1 deletion ...common/include/autoware/behavior_path_planner_common/interface/scene_module_interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@
/**
* @brief Explicitly set the initial state
*/
virtual ModuleStatus setInitState() const { return ModuleStatus::RUNNING; }
virtual ModuleStatus setInitState() const { return ModuleStatus::WAITING_APPROVAL; }

Check warning on line 466 in planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/interface/scene_module_interface.hpp

View check run for this annotation

Codecov / codecov/patch

planning/behavior_path_planner/autoware_behavior_path_planner_common/include/autoware/behavior_path_planner_common/interface/scene_module_interface.hpp#L466 

Added line #L466 was not covered by tests

/**
* @brief Get candidate path. This information is used for external judgement.
Expand Down
Loading