-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto enhancement #594
Merged
Merged
Crypto enhancement #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to mojtaba_crypto_enhancement
|
mojtaba-bisheh
force-pushed
the
mojtaba_crypto_enhancement
branch
from
September 19, 2024 17:00
b3fca03
to
4a5ab72
Compare
Nitsirks
previously approved these changes
Sep 19, 2024
… updated timestamp and hash after successful run
… updated timestamp and hash after successful run
upadhyayulakiran
approved these changes
Oct 11, 2024
calebofearth
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced crypto modules including:
remove deadcode in doe_core_cbc (found by FPV)
dead code in line 254-255 doe_core_cbc.sv:
else if(enc_ready)
IV_enc_state <= st_IV_engine_idle;
froze adder inputs to fix [ECC] add_sub_mod_alter ready not aligned with result #194 (found by FPV)
With this PR, there is no more constraints on keeping inputs fixed. The only constraint is having a single pulse add_en_i, and do not enable it again until ready_o.
remove sca_en_i since countermeasures are hardcoded to be enabled (found by FPV)
remove deadcode in ecc_pm_ctrl:163 (found by FPV)
in ecc_pm_ctrl:163 the last else if () is always taken. This PR switches to just else to avoid confusion.
Stop faulty ECC from continuing before zeroize (found by FPV): When the error happens for the first time, the error flag goes high and will remain high until zeroize. We expect that uC issues zeroize if there is an error in ECC. In this scenario, although the second command will be performed, the results should not be used since error flag is kept high. However, this PR stops faulty ECC from continuing before zeroize.
removed one cycle delay for hmac_drbg ready (found by FPV)
This PR synchronizes hmac_drbg READY to VALID by removing one cycle delay
add all_1 protection for LFSR
This PR has protection for the LFSR to stuck to be all 1.
Remove zeroize for the counter used as countermeasure (found by IOActive)
Remove one extra iteration in ecc_scalar_blinding (found by FPV)
In line 300 of scalar_blinding, we have a loop of 20 iterations (0 to 19). However, when we enter the last round, the scalar blinding flag changes to done and we don't perform the last iteration. This PR reduces the iteration by one by updating FULL_DIG_NUM.