fix: upgrade packages to latest, especially @typescript-eslint versions to 8.18.0#15
Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrom Dec 11, 2024
Merged
Conversation
JoshuaKGoldberg
approved these changes
Dec 11, 2024
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Good call, thanks!
I'll go ahead and bump all the packages to their latest versions. Some of them are still on v6!
JoshuaKGoldberg
changed the title
| { ignores: ["lib"] }, | ||
| eslint.configs.recommended, | ||
| ...tseslint.configs.recommendedTypeChecked, | ||
| tseslint.configs.recommendedTypeChecked, |
Member
There was a problem hiding this comment.
In the latest versions, the ... is no longer necessary. Arbitrary nesting is now allowed.
| { | ||
| extends: [tseslint.configs.disableTypeChecked], | ||
| files: ["*.js"], | ||
| ...tseslint.configs.disableTypeChecked, |
Member
There was a problem hiding this comment.
tseslint.config's extends actually always worked this way, I'd just not gotten in the habit of using it nicely.
| "compilerOptions": { | ||
| "module": "NodeNext", | ||
| "moduleResolution": "NodeNext", | ||
| "noEmit": true, |
Member
There was a problem hiding this comment.
This should have been on before, so that if you ran npm run tsc before npm run lint you wouldn't have extra src/*.js files to lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade versions to fix #14